Remove calls to logging.basicConfig on import #194
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@derekhiggins please take a look |
Contributor
|
hmm, we also have setup_logger in https://github.com/instructlab/sdg/blob/main/src/instructlab/sdg/logger_config.py |
Contributor
Author
|
Is |
Contributor
Author
|
@derekhiggins I filed #196 for the logging problem. |
Contributor
Just a library IMO 👍 |
Contributor
|
This pull request has merge conflicts that must be resolved before it can be |
`generate_data` now uses a module-level logger like the rest of the code. The `logger` parameter is now optional. Signed-off-by: Christian Heimes <[email protected]>
Fixes instructlab#196 instructlab.sdg calls logging.basicConfig on import. Libraries should not configure logging themselves. It's the job of the application or main script to configure logging and set up log handlers according to their needs. logging.basicConfig is a one-shot API. The second and any following call are a no-op, unless it is called with force=True. Remove setup_logging and just use logging.getLogger in the code. Co-authored-by: Christian Heimes <[email protected]> Signed-off-by: Mark McLoughlin <[email protected]>
markmc
changed the title
markmc
approved these changes
Jul 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #196
commit 81a69bb
commit 76a8624